Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RQ: reuse same names as before for Docker entrypoints #4574

Merged
merged 1 commit into from
Feb 27, 2020
Merged

RQ: reuse same names as before for Docker entrypoints #4574

merged 1 commit into from
Feb 27, 2020

Conversation

rauchy
Copy link
Contributor

@rauchy rauchy commented Jan 28, 2020

Now that we no longer have Celery around, let's see if we can have the same Docker entrypoints (i.e. functions of the docker_entrypoint script) as before to make upgrades simpler for people.

The only one I'm not sure about is scheduler.

@arikfr arikfr added the Backend label Jan 22, 2020
@arikfr arikfr added this to the v9 milestone Jan 22, 2020
@weekly-digest weekly-digest bot mentioned this pull request Jan 27, 2020
Closed
@rauchy
Copy link
Contributor

rauchy commented Jan 28, 2020 •
edited
Loading

Before we migrated to RQ, we used to have 3 relevant entry points:

worker, dev_worker and scheduler. We still have all of those, but after migration we have dev_scheduler as well, which does the same as scheduler but with code reloads.

The celery_healthcheck function is no longer relevant, as our Supervisor setup runs healthcheck automatically. How about we just add a deprecation message?

@rauchy rauchy requested a review from arikfr February 2, 2020 10:23
@weekly-digest weekly-digest bot mentioned this pull request Feb 3, 2020
Closed
@arikfr
Copy link
Member Author

arikfr commented Feb 3, 2020

Previously you could use scheduler to handle the default queue. But that's no more.

Maybe we should use Supervisor to execute two processes when running scheduler in "compatibility" mode? (one for processing jobs and one for scheduler)

@weekly-digest weekly-digest bot mentioned this pull request Feb 10, 2020
Closed
@arikfr arikfr merged commit b0f1cdd into master Feb 27, 2020
@arikfr arikfr deleted the docker-entrypoint-celery-cleanup branch February 27, 2020 15:56
@weekly-digest weekly-digest bot mentioned this pull request Mar 2, 2020
Closed
@chr0m1ng chr0m1ng mentioned this pull request Feb 1, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arikfr arikfr Awaiting requested review from arikfr

Assignees

@rauchy rauchy

Labels
Backend
Projects
None yet
Milestone
v9
Development

Successfully merging this pull request may close these issues.
2 participants
@rauchy @arikfr